Issue 27983005: Make getLineDash return [] instead of null if it has not yet been set.

Issue 27983005: Make getLineDash return [] instead of null if it has not yet been set. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna

Modified:
7 years, 2 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make getLineDash return [] instead of null if it has not yet been set. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=29013

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -3 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		3 chunks	+33 lines, -2 lines	0 comments	Download
M	tests/html/canvasrenderingcontext2d_test.dart	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/27983005/diff/60001/tests/html/canvasrenderingcontext2d_test.dart File tests/html/canvasrenderingcontext2d_test.dart (right): https://codereview.chromium.org/27983005/diff/60001/tests/html/canvasrenderingcontext2d_test.dart#newcode252 tests/html/canvasrenderingcontext2d_test.dart:252: List<num> old=context.getLineDash(); old = context... https://codereview.chromium.org/27983005/diff/60001/tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate (right): ...

7 years, 2 months ago (2013-10-22 00:50:40 UTC) #2

Emily Fortuna

7 years, 2 months ago (2013-10-22 17:41:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r29013 (presubmit successful).

Expand Messages | Collapse Messages