Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 279453003: Make fill parameter in context2d default to 'nonzero' as per the spec. (Closed)

Created:
6 years, 7 months ago by Emily Fortuna
Modified:
6 years, 7 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make fill parameter in context2d default to 'nonzero' as per the spec. BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=36134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Reapply fix for: https://code.google.com/p/dart/issues/detail?id=15782 This boils down to the old null/undefined issue in the JS ...
6 years, 7 months ago (2014-05-12 21:39:14 UTC) #1
Jacob
lgtm
6 years, 7 months ago (2014-05-13 20:53:59 UTC) #2
Emily Fortuna
6 years, 7 months ago (2014-05-13 21:04:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698