Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 278983004: Improve error messages in MirrorSystem.findLibrary. (Closed)

Created:
6 years, 7 months ago by rmacnak
Modified:
6 years, 7 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz
Visibility:
Public.

Description

Improve error messages in MirrorSystem.findLibrary. BUG=http://dartbug.com/18532 R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=36048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M runtime/lib/mirrors_patch.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
E.g., LibraryMirror on 'dart.core' Exception: There are multiple libraries named 'x': [file:///media/SolidState/dart-git/dart/a.dart, file:///media/SolidState/dart-git/dart/b.dart] Exception: There ...
6 years, 7 months ago (2014-05-09 23:07:37 UTC) #1
gbracha
lgtm
6 years, 7 months ago (2014-05-10 00:06:23 UTC) #2
rmacnak
6 years, 7 months ago (2014-05-12 17:52:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698