dart2dart: Method and constructor calls in new backend.

dart2dart: Method and constructor calls in new backend.

Also string literals and a fix in the frontend's unparser.

BUG=
R=kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36017

[Kevin Millikin (Google), 2014-05-09 10:21:22]

Nice.  Here are comments on the IL and builder --- I'm still reading the tree
generation.

https://codereview.chromium.org/278823002/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right):

https://codereview.chromium.org/278823002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:542:
assert(isOpen);
Move the assert up above the call to giveup.

https://codereview.chromium.org/278823002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:545: List arguments
= node.arguments.toList(growable:false)
This won't really handle optional/default arguments here.  In StaticSend, we use
selector.addArgumentsToList to giveup on them.

https://codereview.chromium.org/278823002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:671: return v;
I actually think the better way to model this is that the value of the setter is
the value of the right-hand side and the result of the invoke is unused.

let prim v0 = ...receiver... in
let prim v1 = ...argument... in
let cont k v2 = ...continuation using v1 as result... in
  InvokeMethod(v0, selector, k, [v1])

One advantage is that anything we know about v1 we also know about the result of
the setter if used.  So here, return args.last instead of v?

https://codereview.chromium.org/278823002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:687:
List<ir.Definition> args = node.send.arguments.toList(growable:false)
There can also be optional arguments here.

https://codereview.chromium.org/278823002/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart (right):

https://codereview.chromium.org/278823002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart:131: 
Make sure to tell the editor to strip trailing whitespace.

[Kevin Millikin (Google), 2014-05-09 11:12:58]

And it LGTM with the fix to setter return values mentioned before.

https://codereview.chromium.org/278823002/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart
(right):

https://codereview.chromium.org/278823002/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart:1:
library dart_codegen;
This file also needs the copyright header.

https://codereview.chromium.org/278823002/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart
(right):

https://codereview.chromium.org/278823002/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:435:
Expression invoke = new InvokeConstructor(
I would break this at = since it is the lowest precedence operator:

Expression invoke =
    new InvokeConstructor(node.type, node.target, arguments);

Or if that doesn't fit, break at the comma not the '(':

Expression invoke = new InvokeConstructor(node.type,
                                          node.target,
                                          arguments);

which uses one fewer line anyway.

https://codereview.chromium.org/278823002/diff/40001/tests/co19/co19-dart2dar...
File tests/co19/co19-dart2dart.status (left):

https://codereview.chromium.org/278823002/diff/40001/tests/co19/co19-dart2dar...
tests/co19/co19-dart2dart.status:98:
Language/12_Expressions/27_Unary_Expressions_A01_t01: fail # co19-roll r546:
Please triage this failure
Great!

[sigurdm, 2014-05-09 11:54:48]

https://codereview.chromium.org/278823002/diff/80001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart
(right):

https://codereview.chromium.org/278823002/diff/80001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:600: for
(int i = node.arguments.length - 1; i >= 0; --i) {
@kevin: Why do we have to do this backwards?

[Kevin Millikin (Google), 2014-05-09 13:04:42]

https://codereview.chromium.org/278823002/diff/80001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart
(right):

https://codereview.chromium.org/278823002/diff/80001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:600: for
(int i = node.arguments.length - 1; i >= 0; --i) {
On 2014/05/09 11:54:49, sigurdm wrote:
> @kevin: Why do we have to do this backwards?

The long answer is that we are implementing the reduction rule:

let x = M in C[x] ==> C[M]

which is an axiom for reasoning about call-by-value languages (sometimes called
beta-omega) where M is any term and C is a left-to-right evaluation context (it
also has to be pure --- no observable effects on the path from the hole in the
context and the root of the context).  For function applications, this means
that it is of the form:

C[f(v0, ..., [], Mn, ...)]

where there are only 'values' to the left of the hole in the context.  In the
implementation we start with a function application where all arguments are
variables (values).  If we consider the arguments right-to-left and rewrite on
the fly, then each argument we consider is in such a left-to-right evaluation
context because the arguments to its left are still variables.

:)

[asgerf, 2014-05-12 07:25:25]

Committed patchset #6 manually as r36017 (presubmit successful).