When mirrors are used with deferred loading we now go through all

When mirrors are used with deferred loading we now go through all
elements and query compiler.backend.isNeededForReflection for each of
them.

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36092

[sigurdm, 2014-05-09 11:27:05]

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (left):

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:306: ?
element.treeElements
.treeElements is not always present on a TypedefElement it turned out on
greentea. It should be investigated further.

[karlklose, 2014-05-12 06:53:12]

LGTM.

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (left):

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:306: ?
element.treeElements
On 2014/05/09 11:27:05, sigurdm wrote:
> .treeElements is not always present on a TypedefElement it turned out on
> greentea. It should be investigated further.

Please file a bug and add a TODO.

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (right):

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:430: // If there is
a target for this class, but no use of mirrors the
What is a 'target'?

When does it happen, that an unresolved class ends up here?

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:432: if (element is
ClassElement &&!element.isResolved) return;
Missing space before '!element'.

[sigurdm, 2014-05-12 12:10:34]

Patch set 2 + 3.

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (left):

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:306: ?
element.treeElements
On 2014/05/12 06:53:12, karlklose wrote:
> On 2014/05/09 11:27:05, sigurdm wrote:
> > .treeElements is not always present on a TypedefElement it turned out on
> > greentea. It should be investigated further.
> 
> Please file a bug and add a TODO.

This is not a problem after patch set 2 - because we query hasTreeElements in
addMirrorElements.

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (right):

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:430: // If there is
a target for this class, but no use of mirrors the
On 2014/05/12 06:53:12, karlklose wrote:
> What is a 'target'?
> 
> When does it happen, that an unresolved class ends up here?

Done.

https://codereview.chromium.org/278733003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:432: if (element is
ClassElement &&!element.isResolved) return;
On 2014/05/12 06:53:12, karlklose wrote:
> Missing space before '!element'.

Done.

[sigurdm, 2014-05-13 08:29:30]

Committed patchset #3 manually as r36092 (presubmit successful).