pkg/mock: fixes for v0.11

pkg/mock: fixes for v0.11

R=nweiz@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35949

[kevmoo, 2014-05-08 18:37:56]

There are only 2 changes that affect features - see comments below

Everything else is just formatting tweaks

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/mock.dart
File pkg/mock/lib/mock.dart (left):

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/mock.dart#oldco...
pkg/mock/lib/mock.dart:118: 
Functional change #1 - removed deprecated (and unused) top-level method

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/src/mock.dart
File pkg/mock/lib/src/mock.dart (left):

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/src/mock.dart#o...
pkg/mock/lib/src/mock.dart:178: // TODO(gram): Replace all this with:
Functional change #2: use mirror features here

[kevmoo, 2014-05-08 21:27:20]

+ Nathan, if he has a minute

[Siggi Cherem (dart-lang), 2014-05-08 21:41:21]

lgtm

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/src/result_matc...
File pkg/mock/lib/src/result_matcher.dart (right):

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/src/result_matc...
pkg/mock/lib/src/result_matcher.dart:37: description.add('return ');
how about:
description.add(... ? 'return' : 'throw');

[nweiz, 2014-05-08 21:49:27]

I don't know much about this package in particular, but style-wise LGTM.

[kevmoo, 2014-05-08 22:43:27]

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/src/result_matc...
File pkg/mock/lib/src/result_matcher.dart (right):

https://codereview.chromium.org/278613003/diff/1/pkg/mock/lib/src/result_matc...
pkg/mock/lib/src/result_matcher.dart:37: description.add('return ');
On 2014/05/08 21:41:22, Siggi Cherem (dart-lang) wrote:
> how about:
> description.add(... ? 'return' : 'throw');

Trying to leave code mostly as I found it.

[kevmoo, 2014-05-08 22:43:49]

Committed patchset #2 manually as r35949 (presubmit successful).