Issue 278413002: Fix code generation in polymer: we avoided generating types above HtmlElement in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 278413002: Fix code generation in polymer: we avoided generating types above HtmlElement in (Closed)

Created:
6 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix code generation in polymer: we avoided generating types above HtmlElement in all but one place. Added support for that in smoke and polymer. This should fix issue 18667. BUG=https://code.google.com/p/dart/issues/detail?id=18667 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=36053

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -16 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/polymer/lib/src/build/script_compactor.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/polymer/pubspec.yaml	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/smoke/lib/codegen/recorder.dart	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	pkg/smoke/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/smoke/test/codegen/recorder_test.dart	View	2 chunks	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm. Any idea why this behaved differently on buildbots vs running locally?

6 years, 7 months ago (2014-05-12 18:40:38 UTC) #2

Siggi Cherem (dart-lang)

On 2014/05/12 18:40:38, John Messerly wrote: > lgtm. Any idea why this behaved differently on ...

6 years, 7 months ago (2014-05-12 19:22:18 UTC) #3

Siggi Cherem (dart-lang)

6 years, 7 months ago (2014-05-12 19:23:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r36053 (presubmit successful).

Expand Messages | Collapse Messages