Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2778923002: Avoid private override via mixin (Closed)

Created:
3 years, 9 months ago by skybrian
Modified:
3 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M lib/src/protobuf/generated_message.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/protobuf/readonly_message.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
skybrian
3 years, 9 months ago (2017-03-27 21:48:16 UTC) #2
kevmoo
lgtm
3 years, 9 months ago (2017-03-27 21:48:54 UTC) #3
skybrian
3 years, 9 months ago (2017-03-27 21:52:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
814653b49b90b48db3d00781b594068ba4aca59a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698