Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 277773003: Add explicit dependency from analysis_server to mock. (Closed)

Created:
6 years, 7 months ago by Paul Berry
Modified:
6 years, 7 months ago
Reviewers:
jwren, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add explicit dependency from analysis_server to mock. Previously we were relying on the implicit dependency via the unittest package, but this dependency was dropped, causing analysis_server to break. Eventually we want to stop relying on the mock package, but we're not ready for that yet. R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=36144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
Note: this breakage could have been avoided if there had been an analyzer hint to ...
6 years, 7 months ago (2014-05-14 00:16:38 UTC) #1
danrubel
lgtm
6 years, 7 months ago (2014-05-14 00:18:45 UTC) #2
Paul Berry
6 years, 7 months ago (2014-05-14 00:29:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698