Issue 27773002: Converting Polymer and TemplateElement to use deprecated Node.document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27773002: Converting Polymer and TemplateElement to use deprecated Node.document (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Converting Polymer and TemplateElement to use deprecated Node.document Because Polymer dart2js tests actually execute dart, the bots are red because the corresponding changes haven't made it into Dartium. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=28830

Patch Set 1 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	pkg/mdv/lib/src/input_bindings.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/mdv/lib/src/template_iterator.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/lib/src/instance.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 2 months ago (2013-10-17 22:04:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28830 (presubmit successful).

Expand Messages | Collapse Messages