Issue 277633003: Remember previously failed packages when backtracking.

Issue 277633003: Remember previously failed packages when backtracking. (Closed)

Created:
6 years, 7 months ago by Bob Nystrom

Modified:
6 years, 7 months ago

Reviewers:
nweiz, kevmoo

CC:
reviews_dartlang.org, kevmoo

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remember previously failed packages when backtracking. BUG=https://code.google.com/p/dart/issues/detail?id=18666 R=kevmoo@google.com, nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=36077

Patch Set 1 #

Total comments: 4

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -20 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart	View	3 chunks	+12 lines, -15 lines	2 comments	Download
M	sdk/lib/_internal/pub/lib/src/solver/version_queue.dart	View	3 chunks	+19 lines, -0 lines	2 comments	Download
M	sdk/lib/_internal/pub/test/version_solver_test.dart	View	1 chunk	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/277633003/diff/1/sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right): https://codereview.chromium.org/277633003/diff/1/sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart#newcode302 sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:302: return; This return is no longer necessary. https://codereview.chromium.org/277633003/diff/1/sdk/lib/_internal/pub/lib/src/solver/version_queue.dart ...

6 years, 7 months ago (2014-05-12 20:18:55 UTC) #4

Bob Nystrom

Committed patchset #1 manually as r36077 (presubmit successful).

6 years, 7 months ago (2014-05-12 22:07:21 UTC) #5

Bob Nystrom

6 years, 7 months ago (2014-05-12 22:07:55 UTC) #6

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/277633003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/277633003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:302: return;
On 2014/05/12 20:18:55, nweiz wrote:
> This return is no longer necessary.

It is. We're iterating backwards through the list, so this ensures we stop
iterating and avoids the removeRange() at the end.

https://codereview.chromium.org/277633003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/version_queue.dart (right):

https://codereview.chromium.org/277633003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/version_queue.dart:48: /// by skipped by
the backtracker.
On 2014/05/12 20:18:55, nweiz wrote:
> "by skipped" -> "be skipped"

Done.

Expand Messages | Collapse Messages