Issue 277593005: Fix analyzer warnings in the YAML package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 277593005: Fix analyzer warnings in the YAML package. (Closed)

Created:
6 years, 7 months ago by nweiz

Modified:
6 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix analyzer warnings in the YAML package. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=35939

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -16 lines)			Patch
M	pkg/yaml/lib/src/deep_equals.dart	View	3 chunks	+13 lines, -9 lines	0 comments	Download
M	pkg/yaml/lib/src/parser.dart	View	2 chunks	+12 lines, -6 lines	2 comments	Download
M	pkg/yaml/lib/src/yaml_map.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion but LGTM. https://codereview.chromium.org/277593005/diff/1/pkg/yaml/lib/src/parser.dart File pkg/yaml/lib/src/parser.dart (right): https://codereview.chromium.org/277593005/diff/1/pkg/yaml/lib/src/parser.dart#newcode1118 pkg/yaml/lib/src/parser.dart:1118: return null; Most other code ...

6 years, 7 months ago (2014-05-08 21:01:03 UTC) #2

nweiz

https://codereview.chromium.org/277593005/diff/1/pkg/yaml/lib/src/parser.dart File pkg/yaml/lib/src/parser.dart (right): https://codereview.chromium.org/277593005/diff/1/pkg/yaml/lib/src/parser.dart#newcode1118 pkg/yaml/lib/src/parser.dart:1118: return null; On 2014/05/08 21:01:04, Bob Nystrom wrote: > ...

6 years, 7 months ago (2014-05-08 21:18:18 UTC) #3

nweiz

6 years, 7 months ago (2014-05-08 21:18:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r35939 (presubmit successful).

Expand Messages | Collapse Messages