Issue 17894. Scope of metadata on a class is the defining library, not the class.

Issue 17894. Scope of metadata on a class is the defining library, not the class.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17894

Committed: https://code.google.com/p/dart/source/detail?r=35861

[Brian Wilkerson, 2014-05-07 19:27:05]

LGTM

https://codereview.chromium.org/277523002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java
(right):

https://codereview.chromium.org/277523002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java:139:
private AstNode classWithAlreadyResolvedMetadata = null;
Will this ever be different than the enclosingClass? If not, why don't we use
the same field for both?

[scheglov, 2014-05-07 19:43:05]

https://codereview.chromium.org/277523002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java
(right):

https://codereview.chromium.org/277523002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java:139:
private AstNode classWithAlreadyResolvedMetadata = null;
On 2014/05/07 19:27:05, Brian Wilkerson wrote:
> Will this ever be different than the enclosingClass? If not, why don't we use
> the same field for both?

Not quite.
The "enclosingClass" field is an Element and we need a node.
I will rename it to "enclosingClassDeclaration".

[scheglov, 2014-05-07 19:46:24]

Committed patchset #1 manually as r35861 (presubmit successful).