Issue 27752004: Remove unused assignment. Fixes pub tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27752004: Remove unused assignment. Fixes pub tests. (Closed)

Created:
7 years, 2 months ago by scheglov

Modified:
7 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove unused assignment. Fixes pub tests. TBR R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28839

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	pkg/analyzer_experimental/lib/analyzer.dart	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r28839 (presubmit successful).

7 years, 2 months ago (2013-10-17 23:55:47 UTC) #2

Brian Wilkerson

LGTM, but I'm interested in knowing why this caused the pub tests to fail.

7 years, 2 months ago (2013-10-18 13:45:02 UTC) #3

scheglov

7 years, 2 months ago (2013-10-18 15:32:13 UTC) #4

Message was sent while issue was closed.

On 2013/10/18 13:45:02, Brian Wilkerson wrote:
> LGTM, but I'm interested in knowing why this caused the pub tests to fail.

Pub uses this analyzer.dart library.

Expand Messages | Collapse Messages