Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 277403002: Make fill parameter default to empty String. (Closed)

Created:
6 years, 7 months ago by Emily Fortuna
Modified:
6 years, 7 months ago
Reviewers:
Leaf, terry
CC:
reviews_dartlang.org, ricow1, Leaf
Visibility:
Public.

Description

Make fill parameter default to empty String. BUG= R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=36054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Fix for: https://code.google.com/p/dart/issues/detail?id=15782 This boils down to the old null/undefined issue in the JS version ...
6 years, 7 months ago (2014-05-12 17:14:53 UTC) #1
Leaf
lgtm
6 years, 7 months ago (2014-05-12 17:49:17 UTC) #2
Emily Fortuna
6 years, 7 months ago (2014-05-12 19:30:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698