Generic typedefs and their referents.

Generic typedefs and their referents.

BUG=http://dartbug.com/12282
R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28972

[regis, 2013-10-21 19:42:26]

LGTM

https://codereview.chromium.org/27728004/diff/110001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/27728004/diff/110001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:844: return type.raw();
Do you care if the type is canonical or not?

https://codereview.chromium.org/27728004/diff/110001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:853: ThrowInvokeError(bound_error);
Are you sure you want to throw the bound error directly? It is a language error,
i.e. compile-time error.

[rmacnak, 2013-10-21 19:57:05]

https://codereview.chromium.org/27728004/diff/110001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/27728004/diff/110001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:844: return type.raw();
On 2013/10/21 19:42:27, regis wrote:
> Do you care if the type is canonical or not?

We do want to deal with canonical types, and rely on this to implement mirror
equality.

Fixed as "return type.Canonicalize();"

https://codereview.chromium.org/27728004/diff/110001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:853: ThrowInvokeError(bound_error);
On 2013/10/21 19:42:27, regis wrote:
> Are you sure you want to throw the bound error directly? It is a language
error,
> i.e. compile-time error.

ThrowInvokeError will wrap it in a MirroredCompilationError. We do the same
thing if ObjectMirror.invoke hits a compile-time error. Unfortunately, this will
be hidden behind a flag in 1.0 (concerns re dart2js), and with the flag unset
ThrowInvokeError will propagate the error directly, resulting in the isolate
being suspended.

[rmacnak, 2013-10-22 00:00:16]

Committed patchset #10 manually as r28972 (presubmit successful).

[ahe, 2013-10-30 08:42:25]

DBC

https://codereview.chromium.org/27728004/diff/190001/tests/lib/mirrors/generi...
File tests/lib/mirrors/generic_function_typedef_test.dart (right):

https://codereview.chromium.org/27728004/diff/190001/tests/lib/mirrors/generi...
tests/lib/mirrors/generic_function_typedef_test.dart:28: TypedefMirror
predicateOfNum = reflectClass(C).variables[#predicateOfNum].type;
Many long lines in this file.

Please take action to ensure that you catch long lines before uploading reviews:

As far as I know, the Editor as a line to help you stay below the limit.

If you're using Emacs or VI, let me know, I should be able to give you some
configuration magic that helps you notice long lines.