Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 27705003: Improve canonicalization of strict comparisons and bool negation. (Closed)

Created:
7 years, 2 months ago by Florian Schneider
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Improve canonicalization of strict comparisons and bool negation. This CL generalizes the existing optimization to handle all combinations expr === true expr !== true expr === false expr !== false including lhs and rhs swapped. It also adds canonicalization of boolean negation. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=28802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -19 lines) Patch
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +51 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 2 months ago (2013-10-17 13:51:28 UTC) #1
Kevin Millikin (Google)
lgtm
7 years, 2 months ago (2013-10-17 14:00:17 UTC) #2
Florian Schneider
7 years, 2 months ago (2013-10-17 14:01:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28802 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698