Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 276683002: Fix issue 18665. Avoid exposing a null-ptr in Function's code field. (Closed)

Created:
6 years, 7 months ago by Florian Schneider
Modified:
6 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra
Visibility:
Public.

Description

Fix issue 18665. Avoid exposing a null-ptr in Function's code field. The code field has to be initialized before any GC can happen. BUG=dartbug.com/18665 TEST=isolate/mandel_isolate_test R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=36018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
6 years, 7 months ago (2014-05-08 08:55:48 UTC) #1
Ivan Posva
LGTM -ip
6 years, 7 months ago (2014-05-09 17:24:15 UTC) #2
Florian Schneider
6 years, 7 months ago (2014-05-12 09:15:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698