Issue 276563005: Fix tools/dartium/test.py path computation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276563005: Fix tools/dartium/test.py path computation. (Closed)

Created:
6 years, 7 months ago by Bill Hesse

Modified:
6 years, 7 months ago

Reviewers:
ricow1, vsm

CC:
reviews_dartlang.org, ricow1, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix tools/dartium/test.py path computation. BUG= R=ricow@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=36100

Patch Set 2 : Address comment. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/dartium/test.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

This script was copied from src/dartium_tools to src/dart/tools/dartium, so the path to src is different.

6 years, 7 months ago (2014-05-13 11:51:52 UTC) #1

ricow1

lgtm https://codereview.chromium.org/276563005/diff/1/tools/dartium/test.py File tools/dartium/test.py (right): https://codereview.chromium.org/276563005/diff/1/tools/dartium/test.py#newcode146 tools/dartium/test.py:146: fullpath = os.path.abspath(pathname) add a comment saying: # ...

6 years, 7 months ago (2014-05-13 11:55:47 UTC) #3

Bill Hesse

6 years, 7 months ago (2014-05-13 11:59:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36100 (presubmit successful).

Expand Messages | Collapse Messages

Issue 276563005: Fix tools/dartium/test.py path computation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages