new ByteStreamClientChannel

new ByteStreamClientChannel

BUG=dartbug.com/18632
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36059

[danrubel, 2014-05-10 01:20:09]

For use by Dart clients wanting to communicate with analysis server over
stdin/out

[Paul Berry, 2014-05-11 05:08:59]

lgtm

https://codereview.chromium.org/276113002/diff/1/pkg/analysis_server/test/cha...
File pkg/analysis_server/test/channel_test.dart (right):

https://codereview.chromium.org/276113002/diff/1/pkg/analysis_server/test/cha...
pkg/analysis_server/test/channel_test.dart:210: return
inputSink.flush().timeout(new Duration(seconds: 1)).then((_) {
Using timeouts like this leads to nondeterministic tests (see r35221).  You
should be able to achieve the same effect deterministically using
pumpEventQueue, e.g.:

return inputSink.flush().then(pumpEventQueue()).then((_) {

(similar comment applies to the 2 methods below).

[danrubel, 2014-05-12 20:16:24]

https://codereview.chromium.org/276113002/diff/1/pkg/analysis_server/test/cha...
File pkg/analysis_server/test/channel_test.dart (right):

https://codereview.chromium.org/276113002/diff/1/pkg/analysis_server/test/cha...
pkg/analysis_server/test/channel_test.dart:210: return
inputSink.flush().timeout(new Duration(seconds: 1)).then((_) {
On 2014/05/11 05:09:00, Paul Berry wrote:
> Using timeouts like this leads to nondeterministic tests (see r35221).  You
> should be able to achieve the same effect deterministically using
> pumpEventQueue, e.g.:
> 
> return inputSink.flush().then(pumpEventQueue()).then((_) {
> 
> (similar comment applies to the 2 methods below).

Good idea. Done.

[danrubel, 2014-05-12 20:18:03]

Committed patchset #3 manually as r36059 (presubmit successful).