Issue 276043003: Lay waste to ClosureMirror.findInContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276043003: Lay waste to ClosureMirror.findInContext. (Closed)

Created:
6 years, 7 months ago by rmacnak

Modified:
6 years, 7 months ago

Reviewers:
gbracha, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, bakster

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Lay waste to ClosureMirror.findInContext. BUG=http://dartbug.com/18741 R=gbracha@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=36704

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -680 lines)			Patch
M	runtime/lib/mirrors.cc	View		5 chunks	+0 lines, -302 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/lib/lib.status	View		2 chunks	+0 lines, -8 lines	0 comments	Download
D	tests/lib/mirrors/find_in_context_fake_function_test.dart	View		1 chunk	+0 lines, -79 lines	0 comments	Download
D	tests/lib/mirrors/find_in_context_private_test.dart	View		1 chunk	+0 lines, -104 lines	0 comments	Download
D	tests/lib/mirrors/find_in_context_test.dart	View		1 chunk	+0 lines, -157 lines	0 comments	Download

Total messages: 4 (0 generated)

Ivan Posva

Is this still an active review? If so, LGTM as well. -Ivan

6 years, 7 months ago (2014-05-25 19:05:31 UTC) #3

rmacnak

6 years, 7 months ago (2014-05-27 19:36:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36704 (presubmit successful).