Issue 27602002: Renaming Node.document back to Node.ownerDocument

Issue 27602002: Renaming Node.document back to Node.ownerDocument (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, Jacob

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Renaming Node.document back to Node.ownerDocument With custom elements, the document instance variable creates an odd conflict with the document global. BUG=14099 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=28810

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -31 lines)			Patch
M	pkg/mdv/lib/src/input_bindings.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/mdv/lib/src/template_iterator.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/mdv/test/template_element_test.dart	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	pkg/polymer/lib/src/instance.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	5 chunks	+11 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	7 chunks	+54 lines, -7 lines	2 comments	Download
M	tests/html/custom/entered_left_view_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/27602002/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/27602002/diff/1/sdk/lib/html/dartium/html_dartium.dart#newcode35686 sdk/lib/html/dartium/html_dartium.dart:35686: +class _ScheduleImmediateHelper { curious where this came from? ...

7 years, 2 months ago (2013-10-16 23:09:03 UTC) #2

blois

https://codereview.chromium.org/27602002/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/27602002/diff/1/sdk/lib/html/dartium/html_dartium.dart#newcode35686 sdk/lib/html/dartium/html_dartium.dart:35686: +class _ScheduleImmediateHelper { On 2013/10/16 23:09:03, John Messerly wrote: ...

7 years, 2 months ago (2013-10-16 23:12:35 UTC) #3

blois

7 years, 2 months ago (2013-10-17 17:56:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r28810 (presubmit successful).

Expand Messages | Collapse Messages