Issue 27588004: Fixes a bug in runtime call stub on arm and mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27588004: Fixes a bug in runtime call stub on arm and mips. (Closed)

Created:
7 years, 2 months ago by zra

Modified:
7 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixes a bug in runtime call stub on arm and mips. GC was failing to visit the last argument to runtime calls because the stack frame iterator expects the same layout in the runtime call stub as with other frames. Using the stub entry macro ensures that the last argument is in the expected place. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28803

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -13 lines)			Patch
	M	runtime/vm/stub_code_arm.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
	M	runtime/vm/stub_code_mips.cc	View	1	3 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zra

7 years, 2 months ago (2013-10-17 15:09:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r28803 (presubmit successful).

Expand Messages | Collapse Messages