Issue 27536010: Fixing custom event test on IE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27536010: Fixing custom event test on IE (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing custom event test on IE For some reason, Event.preventDefault on IE is not triggering defaultPrevented back at the call site. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28767

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tests/html/event_customevent_test.dart	View		2 chunks	+5 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/27536010/diff/1/tests/html/event_customevent_test.dart File tests/html/event_customevent_test.dart (right): https://codereview.chromium.org/27536010/diff/1/tests/html/event_customevent_test.dart#newcode65 tests/html/event_customevent_test.dart:65: window.console.log('here' + e.detail); Do we need this print?

7 years, 2 months ago (2013-10-16 23:49:01 UTC) #2

blois

https://codereview.chromium.org/27536010/diff/1/tests/html/event_customevent_test.dart File tests/html/event_customevent_test.dart (right): https://codereview.chromium.org/27536010/diff/1/tests/html/event_customevent_test.dart#newcode65 tests/html/event_customevent_test.dart:65: window.console.log('here' + e.detail); On 2013/10/16 23:49:01, vsm wrote: > ...

7 years, 2 months ago (2013-10-17 00:05:31 UTC) #3

blois

7 years, 2 months ago (2013-10-17 00:05:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r28767 (presubmit successful).

Expand Messages | Collapse Messages