Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 27530002: Reorganize VM Service client (Closed)

Created:
7 years, 2 months ago by Cutch
Modified:
7 years, 2 months ago
Reviewers:
dgrove, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reorganize VM Service client. This CL is largely a move/rename of the sources so they are laid out in the standard directory layout (the other layout is no longer necessary with the single html and js file deployed output). Buried inside the rename is the out/ directory which contains the observatory deployed as a single js file + html/img assets. bootstrap_css DEPS have been updated already. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28740

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1337 lines) Patch
M runtime/bin/bin.gypi View 1 3 chunks +1 line, -6 lines 0 comments Download
M runtime/bin/resources_sources.gypi View 1 1 chunk +11 lines, -256 lines 0 comments Download
M runtime/bin/vmservice/client/.gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
A runtime/bin/vmservice/client/build.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
D runtime/bin/vmservice/client/favicon.ico View 1 Binary file 0 comments Download
D runtime/bin/vmservice/client/img/isolate_icon.png View 1 Binary file 0 comments Download
runtime/bin/vmservice/client/index.html View 1 1 chunk +0 lines, -168 lines 0 comments Download
D runtime/bin/vmservice/client/index.html_bootstrap.dart View 1 1 chunk +0 lines, -34 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/observatory.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/observatory_elements.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/observatory_elements.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory/application.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory/isolate.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/collapsible_content.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/collapsible_content.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/img/isolate_icon.png View 1 Binary file 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/navigation_bar.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/navigation_bar.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_application.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_application.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/response_viewer.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/response_viewer.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D runtime/bin/vmservice/client/observatory_main.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
A + runtime/bin/vmservice/client/out/web/favicon.ico View 1 Binary file 0 comments Download
A + runtime/bin/vmservice/client/out/web/img/isolate_icon.png View 1 Binary file 0 comments Download
A + runtime/bin/vmservice/client/out/web/index.html View 1 3 chunks +6 lines, -3 lines 0 comments Download
A + runtime/bin/vmservice/client/out/web/index.html_bootstrap.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/out/web/observatory_main.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/observatory.dart View 1 1 chunk +0 lines, -13 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/observatory_elements.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/observatory_elements.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory/application.dart View 1 1 chunk +0 lines, -35 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory/isolate.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory/isolate_manager.dart View 1 1 chunk +0 lines, -51 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory/location_manager.dart View 1 1 chunk +0 lines, -123 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory/request_manager.dart View 1 1 chunk +0 lines, -64 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/collapsible_content.dart View 1 1 chunk +0 lines, -46 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/collapsible_content.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/error_view.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/error_view.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/img/isolate_icon.png View 1 Binary file 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_list.dart View 1 1 chunk +0 lines, -13 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_list.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_summary.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_summary.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/json_view.dart View 1 1 chunk +0 lines, -56 lines 0 comments Download
runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/json_view.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/message_viewer.dart View 1 1 chunk +0 lines, -34 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/message_viewer.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/navigation_bar.dart View 1 1 chunk +0 lines, -12 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/navigation_bar.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_application.dart View 1 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_application.html View 1 1 chunk +0 lines, -12 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_element.dart View 1 1 chunk +0 lines, -17 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_element.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/response_viewer.dart View 1 1 chunk +0 lines, -12 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/response_viewer.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/stack_trace.dart View 1 1 chunk +0 lines, -13 lines 0 comments Download
runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/stack_trace.html View 1 1 chunk +0 lines, -27 lines 0 comments Download
A runtime/bin/vmservice/client/pubspec.yaml View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + runtime/bin/vmservice/client/web/favicon.ico View 1 Binary file 0 comments Download
A + runtime/bin/vmservice/client/web/img/isolate_icon.png View 1 Binary file 0 comments Download
A runtime/bin/vmservice/client/web/index.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + runtime/bin/vmservice/client/web/observatory_main.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
runtime/bin/vmservice/gen_resources_sources.sh View 1 1 chunk +0 lines, -49 lines 0 comments Download
M runtime/bin/vmservice_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/tools/create_resources.py View 1 6 chunks +8 lines, -53 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
7 years, 2 months ago (2013-10-16 16:25:38 UTC) #1
Ivan Posva
LGTMwC -ip https://codereview.chromium.org/27530002/diff/1/runtime/bin/vmservice/client/lib/observatory.dart File runtime/bin/vmservice/client/lib/observatory.dart (right): https://codereview.chromium.org/27530002/diff/1/runtime/bin/vmservice/client/lib/observatory.dart#newcode1 runtime/bin/vmservice/client/lib/observatory.dart:1: library observatory; No changes in this file? ...
7 years, 2 months ago (2013-10-16 17:31:10 UTC) #2
Cutch
https://codereview.chromium.org/27530002/diff/1/runtime/bin/vmservice/client/out/web/index.html File runtime/bin/vmservice/client/out/web/index.html (right): https://codereview.chromium.org/27530002/diff/1/runtime/bin/vmservice/client/out/web/index.html#newcode40 runtime/bin/vmservice/client/out/web/index.html:40: <img src="img/isolate_icon.png" class="img-polaroid"> On 2013/10/16 17:31:11, Ivan Posva wrote: ...
7 years, 2 months ago (2013-10-16 17:35:28 UTC) #3
Cutch
7 years, 2 months ago (2013-10-16 17:50:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698