Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 27529003: Revert "Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "… (Closed)

Created:
7 years, 2 months ago by zarah
Modified:
7 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type of Iterable."." This reverts commit r28726. Committed: https://code.google.com/p/dart/source/detail?r=28730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -269 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 6 chunks +0 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 3 chunks +6 lines, -7 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart View 1 chunk +0 lines, -143 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 2 chunks +10 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart View 1 chunk +3 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 5 chunks +11 lines, -17 lines 0 comments Download
M sdk/lib/_internal/lib/js_rti.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M tests/lib/mirrors/class_mirror_type_variables_test.dart View 2 chunks +4 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zarah
TBR.
7 years, 2 months ago (2013-10-16 16:13:23 UTC) #1
zarah
Committed patchset #1 manually as r28730 (presubmit successful).
7 years, 2 months ago (2013-10-16 16:13:31 UTC) #2
ahe
7 years, 2 months ago (2013-10-16 16:16:27 UTC) #3
Message was sent while issue was closed.
lgtm

:-(

Powered by Google App Engine
This is Rietveld 408576698