Issue 27525007: Remove conflict between type parameter and method/field from typevariable_mirror_metadata_test. Rem…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27525007: Remove conflict between type parameter and method/field from typevariable_mirror_metadata_test. Rem… (Closed)

Created:
7 years, 2 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
ahe, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove conflict between type parameter and method/field from typevariable_mirror_metadata_test. Remove irregularity in metadata lookup naming that dealt with allow their co-existence. BUG=http://dartbug.com/13327 BUG=http://dartbug.com/14016 Committed: https://code.google.com/p/dart/source/detail?r=28815

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -32 lines)			Patch
M	runtime/vm/object.cc	View		1 chunk	+5 lines, -11 lines	0 comments	Download
M	tests/lib/lib.status	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tests/lib/mirrors/typevariable_mirror_metadata_test.dart	View		2 chunks	+2 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Committed patchset #2 manually as r28815 (presubmit successful).

7 years, 2 months ago (2013-10-17 18:49:34 UTC) #2

Message was sent while issue was closed.

Test LGTM!

Expand Messages | Collapse Messages