Practically remove boot.js, adds the initialization from the Dart side of

Practically remove boot.js, adds the initialization from the Dart side of
things, and fixes examples to work this way.

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28773

[Siggi Cherem (dart-lang), 2013-10-17 01:46:48]

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/boot.dart
File pkg/polymer/lib/src/boot.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/boot.d...
pkg/polymer/lib/src/boot.dart:5: /** Ported from `polymer/src/boot.js`. **/
this matches polymer's code structure. The code below is from the same commit#
that we've used so far for all the other polymer code. They seem to have added
some fancier FUOC logic, though

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/import_inliner.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/import_inliner.dart:128: if (url != null && url != ''
&& !url.startsWith('{{')) {
this is to fix: dartbug.com/13636

[Jennifer Messerly, 2013-10-17 02:04:34]

Wow! This change is made of pure awesome. LGTM other than a few minor comments

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/import_inliner.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/import_inliner.dart:128: if (url != null && url != ''
&& !url.startsWith('{{')) {
On 2013/10/17 01:46:49, Siggi Cherem (dart-lang) wrote:
> this is to fix: dartbug.com/13636

awesome! Not for this change but, I wonder if we should expose "assetpath"?

https://github.com/Polymer/labs/blob/37d8a25643c31b7f9acd2525208b0686a4933887...

and

https://github.com/Polymer/polymer/blob/70b79c7b37a0153b8aa572c6cb3757df07c3c...

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/linter.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/linter.dart:384: _logger.warning('script tag missing
type="application/dart".',
not a big deal either way, but these 2 messages could be consolidated

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/polyfill_injector.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/polyfill_injector.dart:77: if (!shadowDomFound)
_addScript('shadow_dom/shadow_dom.debug.js');
if you want to fix: this can be .min now, 13046 is fixed.

actually, we probably want to tie this to the "Pub build" settings ... if
dart2js is building minified we should include minified polyfills, else debug
polyfills. can we fix now, or should I open a bug to track this issue?

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
File pkg/polymer/lib/src/loader.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:22: *   * initialize MDV
initialize Model-Driven Views (MDV)

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:23: *   * Include some style to prevent FUOC
Include some style to prevent flash of unstyled content (FOUC)

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:41: preventFuoc();
Rename this "preventFlashOfUnstyledContent"?

alternatively should be Fouc? ("o" and "u" reversed?)

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:52: window.onLoad.listen((_) {
do we need to worry about initPolymer being called after onLoad fires?

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:101: final _rootUri =
currentMirrorSystem().isolate.rootLibrary.uri;
do we have a bug # about this?

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/test/instance_...
File pkg/polymer/test/instance_attrs_test.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/test/instance_...
pkg/polymer/test/instance_attrs_test.dart:16: // TODO(sigmund): remove this?
Funny, I almost added this line. I wonder why this was working for me?

in any case -- I don't think you need a TODO; it's a reasonable thing for the
test to do

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
File samples/third_party/todomvc/web/index.html (right):

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
samples/third_party/todomvc/web/index.html:12: <script type="application/dart"
src="packages/polymer/init.dart"></script>
question -- why is the script first in this example but not in many of the
others? I do like having it in head, just wondering.

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
File samples/third_party/todomvc/web/router_options.dart (left):

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
samples/third_party/todomvc/web/router_options.dart:21: factory RouterOptions()
=> new Element.tag('router-options');
even though it's unused, should we keep this to show how to make programmatic
creation work?

[Siggi Cherem (dart-lang), 2013-10-17 02:37:39]

thanks!

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/import_inliner.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/import_inliner.dart:128: if (url != null && url != ''
&& !url.startsWith('{{')) {
On 2013/10/17 02:04:35, John Messerly wrote:
> On 2013/10/17 01:46:49, Siggi Cherem (dart-lang) wrote:
> > this is to fix: dartbug.com/13636
> 
> awesome! Not for this change but, I wonder if we should expose "assetpath"?
> 
>
https://github.com/Polymer/labs/blob/37d8a25643c31b7f9acd2525208b0686a4933887...
> 
> and
> 
>
https://github.com/Polymer/polymer/blob/70b79c7b37a0153b8aa572c6cb3757df07c3c...

interesting, I need to take a closer look.

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/linter.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/linter.dart:384: _logger.warning('script tag missing
type="application/dart".',
On 2013/10/17 02:04:35, John Messerly wrote:
> not a big deal either way, but these 2 messages could be consolidated

Done.

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/polyfill_injector.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/polyfill_injector.dart:77: if (!shadowDomFound)
_addScript('shadow_dom/shadow_dom.debug.js');
On 2013/10/17 02:04:35, John Messerly wrote:
> if you want to fix: this can be .min now, 13046 is fixed.
> 
> actually, we probably want to tie this to the "Pub build" settings ... if
> dart2js is building minified we should include minified polyfills, else debug
> polyfills. can we fix now, or should I open a bug to track this issue?

:-) funny I thought about fixing this too, but decided to wait. I just have a
feeling this might trigger more failures in the bots and prefer to do it
separately.

I like your idea to do it more sensitive (only when --minify is on)

Filed:
https://code.google.com/p/dart/issues/detail?id=14161

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
File pkg/polymer/lib/src/loader.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:22: *   * initialize MDV
On 2013/10/17 02:04:35, John Messerly wrote:
> initialize Model-Driven Views (MDV)

Done.

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:23: *   * Include some style to prevent FUOC
On 2013/10/17 02:04:35, John Messerly wrote:
> Include some style to prevent flash of unstyled content (FOUC)

Done.

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:41: preventFuoc();
On 2013/10/17 02:04:35, John Messerly wrote:
> Rename this "preventFlashOfUnstyledContent"?
> 
> alternatively should be Fouc? ("o" and "u" reversed?)

Done.

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:52: window.onLoad.listen((_) {
On 2013/10/17 02:04:35, John Messerly wrote:
> do we need to worry about initPolymer being called after onLoad fires?

fixed - I got rid of the onLoad event. This was necessary when I was running the
init code from an html import. In which case I was hitting this bug:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=23526

After the conclusions from today's discussion, I think now it's safe to assume
that this call comes after all HTML imports are resolved.

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/lib/src/loader...
pkg/polymer/lib/src/loader.dart:101: final _rootUri =
currentMirrorSystem().isolate.rootLibrary.uri;
On 2013/10/17 02:04:35, John Messerly wrote:
> do we have a bug # about this?

oops, yes, I removed the TODO when moving the code around. I tried using
window.location.href, but wasn't successful with it. I updated the bug with more
details, added back the TODO

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/test/instance_...
File pkg/polymer/test/instance_attrs_test.dart (right):

https://codereview.chromium.org/27518006/diff/6001/pkg/polymer/test/instance_...
pkg/polymer/test/instance_attrs_test.dart:16: // TODO(sigmund): remove this?
On 2013/10/17 02:04:35, John Messerly wrote:
> Funny, I almost added this line. I wonder why this was working for me?
> 
> in any case -- I don't think you need a TODO; it's a reasonable thing for the
> test to do

:-) - removed TODO. Yeah I'm not sure why it was failing only for me here.

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
File samples/third_party/todomvc/web/index.html (right):

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
samples/third_party/todomvc/web/index.html:12: <script type="application/dart"
src="packages/polymer/init.dart"></script>
On 2013/10/17 02:04:35, John Messerly wrote:
> question -- why is the script first in this example but not in many of the
> others? I do like having it in head, just wondering.

No reason, it could be anywhere (after the imports), the other examples already
had a script tag so I put it next to the existing one.

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
File samples/third_party/todomvc/web/router_options.dart (left):

https://codereview.chromium.org/27518006/diff/6001/samples/third_party/todomv...
samples/third_party/todomvc/web/router_options.dart:21: factory RouterOptions()
=> new Element.tag('router-options');
On 2013/10/17 02:04:35, John Messerly wrote:
> even though it's unused, should we keep this to show how to make programmatic
> creation work?

Done. Now it becomes:
factory RouterOptions() => new Element.tag('ul', 'router-options');

[Siggi Cherem (dart-lang), 2013-10-17 02:44:45]

Committed patchset #2 manually as r28773 (presubmit successful).