Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 27499002: Fix flaky stream_controller_async_test. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reword comment. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M tests/lib/async/event_helper.dart View 5 chunks +14 lines, -12 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 1 1 chunk +3 lines, -10 lines 1 comment Download
M tests/lib/lib.status View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-16 10:43:12 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/27499002/diff/1/tests/lib/async/stream_controller_async_test.dart File tests/lib/async/stream_controller_async_test.dart (right): https://codereview.chromium.org/27499002/diff/1/tests/lib/async/stream_controller_async_test.dart#newcode664 tests/lib/async/stream_controller_async_test.dart:664: // the done event to the asBroadcastStream controller, ...
7 years, 2 months ago (2013-10-16 11:02:04 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/27499002/diff/1/tests/lib/async/stream_controller_async_test.dart File tests/lib/async/stream_controller_async_test.dart (right): https://codereview.chromium.org/27499002/diff/1/tests/lib/async/stream_controller_async_test.dart#newcode664 tests/lib/async/stream_controller_async_test.dart:664: // the done event to the asBroadcastStream controller, which ...
7 years, 2 months ago (2013-10-16 11:27:46 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 manually as r28719 (presubmit successful).
7 years, 2 months ago (2013-10-16 11:29:29 UTC) #4
floitsch
7 years, 2 months ago (2013-10-16 11:42:44 UTC) #5
Message was sent while issue was closed.
Another comment...

https://codereview.chromium.org/27499002/diff/4001/tests/lib/async/stream_con...
File tests/lib/async/stream_controller_async_test.dart (right):

https://codereview.chromium.org/27499002/diff/4001/tests/lib/async/stream_con...
tests/lib/async/stream_controller_async_test.dart:642: var pauseIsDone = false;
variable can be removed now.

Powered by Google App Engine
This is Rietveld 408576698