Bring the YAML package's style up to modern standards.

Bring the YAML package's style up to modern standards.

R=jmesserly@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36386

[kevmoo, 2014-05-08 23:58:33]

DBC. Awesome to see this.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/pubspec.yaml
File pkg/yaml/pubspec.yaml (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/pubspec.yaml#newcode9
pkg/yaml/pubspec.yaml:9: unittest: ">=0.9.0 <0.10.0"
Bump this to <0.11.0 ?

[Bob Nystrom, 2014-05-09 00:18:55]

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/composer.dart
File pkg/yaml/lib/src/composer.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/composer.da...
pkg/yaml/lib/src/composer.dart:81: var result = setAnchor(seq, new
SequenceNode(Tag.yaml('seq'), null));
What's your rule for deciding between ' and "?

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/deep_equals...
File pkg/yaml/lib/src/deep_equals.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/deep_equals...
pkg/yaml/lib/src/deep_equals.dart:25: // If both structures loop in the same
place, they're equal at that point in
Long line.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/deep_equals...
pkg/yaml/lib/src/deep_equals.dart:65: if (!map2.containsKey(key)) return false;
What about extra keys in map2?

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/parser.dart
File pkg/yaml/lib/src/parser.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/parser.dart...
pkg/yaml/lib/src/parser.dart:421: /// [_farthestColumn], and [_farthestContext]
to provide additional information.
Long line.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/parser.dart...
pkg/yaml/lib/src/parser.dart:1017: error("Reserved indicators can't start a
plain scalar");
"."

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/utils.dart
File pkg/yaml/lib/src/utils.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/utils.dart#...
pkg/yaml/lib/src/utils.dart:9: /// Returns the hash code for [obj].
The intent behind this isn't clear. Why is this better/different from
obj.hashCode? Maybe, "Returns a hash code such that structurally equal objects
will have the same hash code."?

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/yaml_map.dart
File pkg/yaml/lib/src/yaml_map.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/yaml_map.da...
pkg/yaml/lib/src/yaml_map.dart:17: ///  *  It NaN, list, and map keys.
"It NaN" -> "It allows NaN".

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/test/yaml_test.dart
File pkg/yaml/test/yaml_test.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/test/yaml_test.dart...
pkg/yaml/test/yaml_test.dart:11: import 'utils.dart';
Is this a new file? I don't see it in the patch.

[nweiz, 2014-05-20 00:15:06]

+jmesserly since Bob is on vacation

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/composer.dart
File pkg/yaml/lib/src/composer.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/composer.da...
pkg/yaml/lib/src/composer.dart:81: var result = setAnchor(seq, new
SequenceNode(Tag.yaml('seq'), null));
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> What's your rule for deciding between ' and "?

None, this is just accidental churn. Changed to the original.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/deep_equals...
File pkg/yaml/lib/src/deep_equals.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/deep_equals...
pkg/yaml/lib/src/deep_equals.dart:25: // If both structures loop in the same
place, they're equal at that point in
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/deep_equals...
pkg/yaml/lib/src/deep_equals.dart:65: if (!map2.containsKey(key)) return false;
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> What about extra keys in map2?

We check that they're the same length above. If there are keys in map2 that
aren't in map1, that means there are also keys in map1 that aren't in map2.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/parser.dart
File pkg/yaml/lib/src/parser.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/parser.dart...
pkg/yaml/lib/src/parser.dart:421: /// [_farthestColumn], and [_farthestContext]
to provide additional information.
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/parser.dart...
pkg/yaml/lib/src/parser.dart:1017: error("Reserved indicators can't start a
plain scalar");
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> "."

[error] automatically adds a period.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/utils.dart
File pkg/yaml/lib/src/utils.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/utils.dart#...
pkg/yaml/lib/src/utils.dart:9: /// Returns the hash code for [obj].
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> The intent behind this isn't clear. Why is this better/different from
> obj.hashCode? Maybe, "Returns a hash code such that structurally equal objects
> will have the same hash code."?

Done.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/yaml_map.dart
File pkg/yaml/lib/src/yaml_map.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/lib/src/yaml_map.da...
pkg/yaml/lib/src/yaml_map.dart:17: ///  *  It NaN, list, and map keys.
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> "It NaN" -> "It allows NaN".

Done.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/pubspec.yaml
File pkg/yaml/pubspec.yaml (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/pubspec.yaml#newcode9
pkg/yaml/pubspec.yaml:9: unittest: ">=0.9.0 <0.10.0"
On 2014/05/08 23:58:33, kevmoo wrote:
> Bump this to <0.11.0 ?

Done.

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/test/yaml_test.dart
File pkg/yaml/test/yaml_test.dart (right):

https://codereview.chromium.org/274953002/diff/1/pkg/yaml/test/yaml_test.dart...
pkg/yaml/test/yaml_test.dart:11: import 'utils.dart';
On 2014/05/09 00:18:56, Bob Nystrom wrote:
> Is this a new file? I don't see it in the patch.

Oops, added.

[Jennifer Messerly, 2014-05-20 18:07:56]

lgtm!

https://codereview.chromium.org/274953002/diff/20001/pkg/yaml/test/utils.dart
File pkg/yaml/test/utils.dart (right):

https://codereview.chromium.org/274953002/diff/20001/pkg/yaml/test/utils.dart...
pkg/yaml/test/utils.dart:1: // Copyright (c) 2011, the Dart project authors. 
Please see the AUTHORS file
2014?

https://codereview.chromium.org/274953002/diff/20001/pkg/yaml/test/utils.dart...
pkg/yaml/test/utils.dart:69: /// Indents each line of [text] so that, when
passed to [cleanUpLiteral], it will
long line

[nweiz, 2014-05-20 21:39:48]

https://codereview.chromium.org/274953002/diff/20001/pkg/yaml/test/utils.dart
File pkg/yaml/test/utils.dart (right):

https://codereview.chromium.org/274953002/diff/20001/pkg/yaml/test/utils.dart...
pkg/yaml/test/utils.dart:1: // Copyright (c) 2011, the Dart project authors. 
Please see the AUTHORS file
On 2014/05/20 18:07:56, John Messerly wrote:
> 2014?

Done.

https://codereview.chromium.org/274953002/diff/20001/pkg/yaml/test/utils.dart...
pkg/yaml/test/utils.dart:69: /// Indents each line of [text] so that, when
passed to [cleanUpLiteral], it will
On 2014/05/20 18:07:56, John Messerly wrote:
> long line

Done.

[nweiz, 2014-05-20 21:40:31]

Committed patchset #3 manually as r36386 (presubmit successful).