Report compile-time error when extending, mixing in or implementing a malformed type.

Report compile-time error when extending, mixing in or implementing a malformed type.

BUG=dartbug.com/13994
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28721

[Johnni Winther, 2013-10-16 10:01:52]

On 2013/10/16 09:47:26, karlklose wrote:

Could you support malformed mixin as well?

[karlklose, 2013-10-16 11:41:12]

On 2013/10/16 10:01:52, Johnni Winther wrote:
> On 2013/10/16 09:47:26, karlklose wrote:
> 
> Could you support malformed mixin as well?

Done.

[karlklose, 2013-10-16 12:13:07]

On 2013/10/16 11:41:12, karlklose wrote:
> On 2013/10/16 10:01:52, Johnni Winther wrote:
> > On 2013/10/16 09:47:26, karlklose wrote:
> > 
> > Could you support malformed mixin as well?
> 
> Done.

PTAL.

[Johnni Winther, 2013-10-16 12:22:23]

lgtm

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3877: if
(mixinType == null || mixinType.kind != TypeKind.INTERFACE) {
How can mixinType be null?

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3930: DartType
supertype = typeResolver.resolveTypeAnnotation(this, superclass);
Call resolveType instead.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3953:
typeResolver.resolveTypeAnnotation(this, link.head);
Ditto.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:717: "Error: Class can't
extend malformed type.",
'A class ... a malformed type' seems less harsh.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:725: "Error: Class can't
implement malformed type.",
Ditto.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:733: "Error: Class can't
mixin malformed type.",
Ditto.

[karlklose, 2013-10-16 12:34:51]

Thanks Johnni!

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3877: if
(mixinType == null || mixinType.kind != TypeKind.INTERFACE) {
On 2013/10/16 12:22:23, Johnni Winther wrote:
> How can mixinType be null?

It could before my rewrite. Removed.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3930: DartType
supertype = typeResolver.resolveTypeAnnotation(this, superclass);
On 2013/10/16 12:22:23, Johnni Winther wrote:
> Call resolveType instead.

Done.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3953:
typeResolver.resolveTypeAnnotation(this, link.head);
On 2013/10/16 12:22:23, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:717: "Error: Class can't
extend malformed type.",
On 2013/10/16 12:22:23, Johnni Winther wrote:
> 'A class ... a malformed type' seems less harsh.

Done.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:725: "Error: Class can't
implement malformed type.",
On 2013/10/16 12:22:23, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/27494002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:733: "Error: Class can't
mixin malformed type.",
On 2013/10/16 12:22:23, Johnni Winther wrote:
> Ditto.

Done.

[karlklose, 2013-10-16 12:52:22]

Committed patchset #4 manually as r28721 (presubmit successful).