Issue 27490003: Wait for transaction to complete, before continuing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27490003: Wait for transaction to complete, before continuing. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
vsm, floitsch, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Wait for transaction to complete, before continuing. This is now required, since futures will be completed within the same transaction window. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=28720

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/html/indexeddb_3_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Vijay, please do comment if this is the wrong fix (if e.g. the 'put' Future ...

7 years, 2 months ago (2013-10-16 12:11:48 UTC) #1

floitsch

LGTM. I would suggest committing (since it unbreaks the build). If it was the wrong ...

7 years, 2 months ago (2013-10-16 12:14:51 UTC) #2

Anders Johnsen

Committed patchset #1 manually as r28720 (presubmit successful).

7 years, 2 months ago (2013-10-16 12:17:03 UTC) #3

blois

7 years, 2 months ago (2013-10-16 16:21:22 UTC) #4

Message was sent while issue was closed.

lgtm, I'll follow up with a minor tweak with
https://codereview.chromium.org/26554008

Thanks for tracking down the fix- normally folks don't want to debug these
indexed db tests :)

Expand Messages | Collapse Messages