Issue 274563011: Ignore non-content divs in htmlToText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274563011: Ignore non-content divs in htmlToText. (Closed)

Created:
6 years, 7 months ago by ahe

Modified:
6 years, 7 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, lukechurch, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
M	dart/site/try/src/html_to_text.dart	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	dart/site/try/src/interaction_manager.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	dart/site/try/src/shadow_root.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/tests/try/try.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

ahe

This fixes source_update_test on Firefox and allows me to use getText more generally.

6 years, 7 months ago (2014-05-08 09:49:40 UTC) #1

ahe

6 years, 7 months ago (2014-05-08 10:21:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35897 (presubmit successful).