Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 274563008: Fix bug in SplayTreeSet when removeWhere removes all elements. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in SplayTreeSet when removeWhere removes all elements. BUG= http://dartbug.com/18676 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M sdk/lib/collection/splay_tree.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/splay_tree_test.dart View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-08 06:16:02 UTC) #1
Søren Gjesse
lgtm
6 years, 7 months ago (2014-05-08 06:54:56 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as r35885 (presubmit successful).
6 years, 7 months ago (2014-05-08 07:33:26 UTC) #3
kasperl
6 years, 7 months ago (2014-05-08 07:35:54 UTC) #4
Message was sent while issue was closed.
Consider filing a merge request for this.

Powered by Google App Engine
This is Rietveld 408576698