Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 27429002: Fixing mirrors on Window, Document and Element (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing mirrors on Window, Document and Element BUG=13654 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=28772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-15 23:37:28 UTC) #1
Emily Fortuna
lgtm
7 years, 2 months ago (2013-10-16 00:22:04 UTC) #2
blois
7 years, 2 months ago (2013-10-17 01:27:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28772 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698