Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 27420002: Throw a dynamic type error instead of a CastError in a type cast with a (Closed)

Created:
7 years, 2 months ago by regis
Modified:
7 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Throw a dynamic type error instead of a CastError in a type cast with a malbounded type (fix issue 14123). Regression test is not checked in yet (see https://codereview.chromium.org/27378002/) R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=28698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -45 lines) Patch
M runtime/vm/flow_graph_builder.cc View 2 chunks +35 lines, -42 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 2 months ago (2013-10-15 22:58:19 UTC) #1
rmacnak
lgtm
7 years, 2 months ago (2013-10-16 00:23:47 UTC) #2
regis
7 years, 2 months ago (2013-10-16 00:39:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698