Add type info to fix analyzer failures for 1.23.0-dev.5.0

Add type info to fix analyzer failures for 1.23.0-dev.5.0

BUG=
R=nweiz@google.com

Committed: https://github.com/dart-lang/test/commit/f8a5a00019f6ae540b0d9b0120ce718400164150

[keertip, 2017-03-10 21:22:38]

keertip@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2017-03-10 21:24:34]

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/load_suite.dart
File lib/src/runner/load_suite.dart (right):

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/load_suite.d...
lib/src/runner/load_suite.dart:69: factory LoadSuite(String name,
SuiteConfiguration config, FutureOr<RunnerSuite> body(),
Long line.

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (right):

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/loader.dart#...
lib/src/runner/loader.dart:168: new LoadException(path, error), stackTrace);
I think it would be cleaner to just add "return null" after this.

https://codereview.chromium.org/2740003005/diff/1/lib/src/util/stream_queue.dart
File lib/src/util/stream_queue.dart (right):

https://codereview.chromium.org/2740003005/diff/1/lib/src/util/stream_queue.d...
lib/src/util/stream_queue.dart:491: final List<T> _list = <T>[];
Just make this "final _list".

[keertip, 2017-03-10 21:30:37]

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/load_suite.dart
File lib/src/runner/load_suite.dart (right):

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/load_suite.d...
lib/src/runner/load_suite.dart:69: factory LoadSuite(String name,
SuiteConfiguration config, FutureOr<RunnerSuite> body(),
On 2017/03/10 21:24:34, nweiz wrote:
> Long line.

Done.

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (right):

https://codereview.chromium.org/2740003005/diff/1/lib/src/runner/loader.dart#...
lib/src/runner/loader.dart:168: new LoadException(path, error), stackTrace);
On 2017/03/10 21:24:34, nweiz wrote:
> I think it would be cleaner to just add "return null" after this.

Done.

https://codereview.chromium.org/2740003005/diff/1/lib/src/util/stream_queue.dart
File lib/src/util/stream_queue.dart (right):

https://codereview.chromium.org/2740003005/diff/1/lib/src/util/stream_queue.d...
lib/src/util/stream_queue.dart:491: final List<T> _list = <T>[];
On 2017/03/10 21:24:34, nweiz wrote:
> Just make this "final _list".

Done.

[nweiz, 2017-03-10 21:49:44]

https://codereview.chromium.org/2740003005/diff/20001/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (right):

https://codereview.chromium.org/2740003005/diff/20001/lib/src/runner/loader.d...
lib/src/runner/loader.dart:169: return null;
With this I think you can get rid of the type annotation above.

[keertip, 2017-03-10 22:18:33]

https://codereview.chromium.org/2740003005/diff/20001/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (right):

https://codereview.chromium.org/2740003005/diff/20001/lib/src/runner/loader.d...
lib/src/runner/loader.dart:169: return null;
On 2017/03/10 21:49:43, nweiz wrote:
> With this I think you can get rid of the type annotation above.

Done.

[nweiz, 2017-03-10 22:20:29]

lgtm

[keertip, 2017-03-10 22:26:28]

Description was changed from

==========
Add type info to fix analyzer failures for 1.23.0-dev.5.0

BUG=
==========

to

==========
Add type info to fix analyzer failures for 1.23.0-dev.5.0

BUG=
R=nweiz@google.com

Committed:
https://github.com/dart-lang/test/commit/f8a5a00019f6ae540b0d9b0120ce71840016...
==========

[keertip, 2017-03-10 22:26:29]

Committed patchset #3 (id:40001) manually as
f8a5a00019f6ae540b0d9b0120ce718400164150 (presubmit successful).