Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 273863002: Add dart-sdk argument when calling the dart based analyzer in the created sdk (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
kasperl, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add dart-sdk argument when calling the dart based analyzer in the created sdk I am not even sure why we need to pass in this argument, but the tool requires this or it will exit with "Usage: dartanalyzer: no Dart SDK found." This is a fix so that we can get a release out, I will leave it to the analyzer people to figure out if this is needed after all. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=35889

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M sdk/bin/dartanalyzer View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 chunk +9 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 7 months ago (2014-05-08 08:11:12 UTC) #1
kasperl
LGTM. https://codereview.chromium.org/273863002/diff/1/sdk/bin/dartanalyzer.bat File sdk/bin/dartanalyzer.bat (right): https://codereview.chromium.org/273863002/diff/1/sdk/bin/dartanalyzer.bat#newcode21 sdk/bin/dartanalyzer.bat:21: IF %SDK_DIR:~-1%==\ set SDK_DIR=%SDK_DIR:~0,-1% IF -> if
6 years, 7 months ago (2014-05-08 08:15:08 UTC) #2
ricow1
Committed patchset #1 manually as r35889 (presubmit successful).
6 years, 7 months ago (2014-05-08 08:18:51 UTC) #3
ricow1
https://codereview.chromium.org/273863002/diff/1/sdk/bin/dartanalyzer.bat File sdk/bin/dartanalyzer.bat (right): https://codereview.chromium.org/273863002/diff/1/sdk/bin/dartanalyzer.bat#newcode21 sdk/bin/dartanalyzer.bat:21: IF %SDK_DIR:~-1%==\ set SDK_DIR=%SDK_DIR:~0,-1% On 2014/05/08 08:15:08, kasperl wrote: ...
6 years, 7 months ago (2014-05-08 08:18:54 UTC) #4
danrubel
6 years, 7 months ago (2014-05-08 14:42:49 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698