Add mirror tests for generic interfaces. Add base-language test for malbounded interfaces.

Add mirror tests for generic interfaces. Add base-language test for malbounded interfaces.

B=http://dartbug.com/14118
R=gbracha@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28703

[rmacnak, 2013-10-15 18:10:57]

Currently dart2js "fails" the new base-level test, and marking it as "Fail" in
the status file doesn't seem to work.

[regis, 2013-10-15 19:04:07]

LGTM

What do you mean by "base-level"? The ..._test/none multitest?

https://codereview.chromium.org/27378002/diff/4001/tests/language/malbounded_...
File tests/language/malbounded_instantiation_test.dart (right):

https://codereview.chromium.org/27378002/diff/4001/tests/language/malbounded_...
tests/language/malbounded_instantiation_test.dart:7: class Malbounded2 extends
Super<String> {}  /// 02: static type warning
If you leave 01: and 02: out, you would verify that the declaration alone
(..._test/none) gets a warning, but no error at runtime.

[rmacnak, 2013-10-15 20:56:57]

On 2013/10/15 19:04:07, regis wrote:
> LGTM
> 
> What do you mean by "base-level"? The ..._test/none multitest?

Base-level is the opposite of meta-level, i.e. the test doesn't use mirrors.


>
https://codereview.chromium.org/27378002/diff/4001/tests/language/malbounded_...
> File tests/language/malbounded_instantiation_test.dart (right):
> 
>
https://codereview.chromium.org/27378002/diff/4001/tests/language/malbounded_...
> tests/language/malbounded_instantiation_test.dart:7: class Malbounded2 extends
> Super<String> {}  /// 02: static type warning
> If you leave 01: and 02: out, you would verify that the declaration alone
> (..._test/none) gets a warning, but no error at runtime.

Multitest complains about a range error in that case :/


I will wait for dart2dart to be green again before committing.

[gbracha, 2013-10-15 22:02:10]

Note that the comments will also effect the results further down the line.

https://codereview.chromium.org/27378002/diff/11001/tests/lib/mirrors/generic...
File tests/lib/mirrors/generic_interface_test.dart (right):

https://codereview.chromium.org/27378002/diff/11001/tests/lib/mirrors/generic...
tests/lib/mirrors/generic_interface_test.dart:40: ClassMirror boundedOfDynamic =
reflectClass(Malbounded).superinterfaces.single;
Why is this not called boundedOfString?

https://codereview.chromium.org/27378002/diff/11001/tests/lib/mirrors/generic...
tests/lib/mirrors/generic_interface_test.dart:42: 
Isn't this interfaceOfFbounded?

[rmacnak, 2013-10-15 22:02:24]

Fixed 2 errors in mirror test, marked mirror test status (failing the substitute
just like the mixins).

Added tests for type checks and type casts with malbounded type. Status file not
correct.

[gbracha, 2013-10-15 22:03:17]

lgtm

[regis, 2013-10-15 22:08:30]

https://codereview.chromium.org/27378002/diff/16001/tests/language/malbounded...
File tests/language/malbounded_type_cast_test.dart (right):

https://codereview.chromium.org/27378002/diff/16001/tests/language/malbounded...
tests/language/malbounded_type_cast_test.dart:13: Expect.throws(() => s as
Malbounded1, (e) => e is CastError);  /// 01: continued
As discussed in another email thread today, this is not a CastError, but a
dynamic type error.

[rmacnak, 2013-10-16 00:37:12]

Updated tests and status files, PTAL.

Issue numbers as-yet-unassigned.

[gbracha, 2013-10-16 00:43:40]

lgtm

[regis, 2013-10-16 00:51:59]

LGTM

[rmacnak, 2013-10-16 01:07:06]

Committed patchset #5 manually as r28703 (presubmit successful).

[ahe, 2013-10-16 07:36:22]

Johnni, could you please take a look at these tests?