Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2736983002: Enabling adding and querying for source maps in a MappingBundle. (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enabling adding and querying for source maps in a MappingBundle. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/source_maps/commit/6c137ef553c304784508d96b47464fa3882ff38d

Patch Set 1 #

Patch Set 2 : Enabling adding and querying for source maps in a MappingBundle. #

Total comments: 2

Patch Set 3 : Enabling adding and querying for source maps in a MappingBundle. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M lib/parser.dart View 1 2 chunks +11 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/parser_test.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
3 years, 9 months ago (2017-03-07 18:03:06 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2736983002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2736983002/diff/20001/CHANGELOG.md#newcode3 CHANGELOG.md:3: methods enabling adding and querying for source maps ...
3 years, 9 months ago (2017-03-07 18:36:33 UTC) #3
Jacob
https://codereview.chromium.org/2736983002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2736983002/diff/20001/CHANGELOG.md#newcode3 CHANGELOG.md:3: methods enabling adding and querying for source maps in ...
3 years, 9 months ago (2017-03-07 19:29:33 UTC) #4
Jacob
3 years, 9 months ago (2017-03-07 19:29:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6c137ef553c304784508d96b47464fa3882ff38d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698