Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 273593008: Sanity check dep installation package on the bots (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Sanity check dep installation package on the bots R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35920

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -8 lines) Patch
M tools/bots/linux_distribution_support.py View 1 2 2 chunks +76 lines, -8 lines 4 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 7 months ago (2014-05-08 13:13:11 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/273593008/diff/40001/tools/bots/linux_distribution_support.py File tools/bots/linux_distribution_support.py (right): https://codereview.chromium.org/273593008/diff/40001/tools/bots/linux_distribution_support.py#newcode60 tools/bots/linux_distribution_support.py:60: if entry.endswith("_amd64.deb"): Only 2 space indent. https://codereview.chromium.org/273593008/diff/40001/tools/bots/linux_distribution_support.py#newcode67 tools/bots/linux_distribution_support.py:67: ...
6 years, 7 months ago (2014-05-08 13:32:55 UTC) #2
ricow1
Thanks https://codereview.chromium.org/273593008/diff/40001/tools/bots/linux_distribution_support.py File tools/bots/linux_distribution_support.py (right): https://codereview.chromium.org/273593008/diff/40001/tools/bots/linux_distribution_support.py#newcode60 tools/bots/linux_distribution_support.py:60: if entry.endswith("_amd64.deb"): On 2014/05/08 13:32:56, Søren Gjesse wrote: ...
6 years, 7 months ago (2014-05-08 17:00:04 UTC) #3
ricow1
6 years, 7 months ago (2014-05-08 17:00:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r35920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698