Generate a class table of all the IDL classes in the database. This table is used

Generate a class table of all the IDL classes in the database. This table is used
to access the C++ class hierachy information to do a proper subtype of check.

The new subtype of check improves the following benchmarks
Dromaeo-drt dom-modify appendChild runs-per-second from 889.0 to 1575.0
Dromaeo-drt dom-modify insertBefore runs-per-second from 592.4075924075925 to 1298.0

The generated class table is as follows:
enum {
    _HistoryCrossFrameClassId = 0,
    _LocationCrossFrameClassId,
    _DOMWindowCrossFrameClassId,
    _DateTimeClassId,
    // New types that are not auto-generated should be added here.

    ANGLEInstancedArraysClassId,
    AbstractWorkerClassId,
    ....
    ....
};
typedef struct {
    const char* class_name;
    int library_id;
    int base_class_id;
    bool is_node;
    bool is_active;
    bool is_event;
} _Classinfo;
typedef _Classinfo _DartWebkitClassInfo[NumWebkitClassIds];

_DartWebkitClassInfo DartWebkitClassInfo = {
    { "_HistoryCrossFrame", DartHtmlLibraryId, -1, false, false, false },
    { "_LocationCrossFrame", DartHtmlLibraryId, -1, false, false, false },
    { "_DOMWindowCrossFrame", DartHtmlLibraryId, -1, false, false, true },
    { "DateTime", DartCoreLibraryId, -1, false, false, false },
    // New types that are not auto-generated should be added here.

    { "AngleInstancedArrays", DartWebGlLibraryId, -1, false, false, false, },
    { "AbstractWorker", DartHtmlLibraryId, -1, false, false, false, },
    .....
    .....
};

R=rmacnak@google.com, vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28821

[siva, 2013-10-16 16:21:07]

synched up to tot.

[rmacnak, 2013-10-16 17:46:28]

LGTM

[vsm, 2013-10-17 18:52:42]

lgtm

https://codereview.chromium.org/27358002/diff/7001/tools/dom/scripts/systemna...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/27358002/diff/7001/tools/dom/scripts/systemna...
tools/dom/scripts/systemnative.py:1189: e = self._emitters.FileEmitter(path)
We could factor this out as a template to make it easier to read.  But, given
that we want to migrate to the chrome code gen fairly soon, I wouldn't waste
much time on it.

[siva, 2013-10-17 20:27:38]

Committed patchset #3 manually as r28821 (presubmit successful).

[blois, 2013-10-18 17:31:38]

https://codereview.chromium.org/27358002/diff/7001/tools/dom/scripts/systemna...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/27358002/diff/7001/tools/dom/scripts/systemna...
tools/dom/scripts/systemnative.py:1188: path = os.path.join(output_dir,
'DartWebkitClassIds.h')
Are there any gyp changes that are needed for this?

I was getting compile issues until I did a clean rebuild (and saw some on the
bots too), not sure if there will be further incremental build issues later.

[siva, 2013-10-19 00:06:45]

https://codereview.chromium.org/27358002/diff/7001/tools/dom/scripts/systemna...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/27358002/diff/7001/tools/dom/scripts/systemna...
tools/dom/scripts/systemnative.py:1188: path = os.path.join(output_dir,
'DartWebkitClassIds.h')
No, no gyp changes are needed for this. The DartWebkitClassIds.h files used to
be generated in "dart/cpp" directory. I moved it to "dart" directory as it was
included in DartUtils etc.

The old DartWebkitClassIds.h file needs to be removed from older clients

On 2013/10/18 17:31:39, blois wrote:
> Are there any gyp changes that are needed for this?
> 
> I was getting compile issues until I did a clean rebuild (and saw some on the
> bots too), not sure if there will be further incremental build issues later.