Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2731933004: Remove FilterRelation.In / "property IN" queries, upgrade googleapis{,_beta} dependencies (Closed)

Created:
3 years, 9 months ago by kustermann
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove FilterRelation.In / "property IN" queries, upgrade googleapis{,_beta} dependencies BUG=https://github.com/dart-lang/gcloud/issues/5 R=vegorov@google.com Committed: https://github.com/dart-lang/gcloud/commit/b27a1a8cb9ca3785ceab74118f530d8a0ac81c61

Patch Set 1 #

Patch Set 2 : add pubspec.yaml update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -55 lines) Patch
M CHANGELOG.md View 1 chunk +11 lines, -0 lines 0 comments Download
M lib/datastore.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/datastore_impl.dart View 1 chunk +2 lines, -18 lines 0 comments Download
M lib/src/db/annotations.dart View 5 chunks +26 lines, -5 lines 0 comments Download
M lib/src/db/db.dart View 3 chunks +2 lines, -15 lines 0 comments Download
M lib/src/db/model_db.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/db/model_db_impl.dart View 3 chunks +10 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/common_e2e.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/datastore/e2e/datastore_test_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/db/e2e/db_test_impl.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M test/db/properties_test.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
kustermann
3 years, 9 months ago (2017-03-06 13:12:16 UTC) #3
Vyacheslav Egorov (Google)
lgtm
3 years, 9 months ago (2017-03-06 13:29:41 UTC) #4
kustermann
3 years, 9 months ago (2017-03-06 14:11:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b27a1a8cb9ca3785ceab74118f530d8a0ac81c61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698