Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 27318003: Avoid generating members for classes only for needed rti. (Closed)

Created:
7 years, 2 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
karlklose, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Avoid generating members for classes only for needed rti. BUG=http://dartbug.com/14105 R=karlklose@google.com, kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 2 chunks +8 lines, -5 lines 0 comments Download
A tests/language/regress_14105_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
7 years, 2 months ago (2013-10-15 14:09:45 UTC) #1
karlklose
LGTM.
7 years, 2 months ago (2013-10-15 14:12:29 UTC) #2
kasperl
LGTM!
7 years, 2 months ago (2013-10-15 14:19:11 UTC) #3
Johnni Winther
7 years, 2 months ago (2013-10-15 15:01:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698