Issue 27308006: Supporting non-SSVs in CustomEvent.detail

Issue 27308006: Supporting non-SSVs in CustomEvent.detail (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
vsm, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Supporting non-SSVs in CustomEvent.detail BUG=12641 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28758

Patch Set 1 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -13 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+31 lines, -7 lines	2 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+24 lines, -2 lines	0 comments	Download
M	tests/html/event_customevent_test.dart	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CustomEvent.darttemplate	View	1 chunk	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/27308006/diff/8001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/27308006/diff/8001/sdk/lib/html/dart2js/html_dart2js.dart#newcode6390 sdk/lib/html/dart2js/html_dart2js.dart:6390: + e._dartDetail = detail; You might run this ...

7 years, 2 months ago (2013-10-16 21:25:33 UTC) #2

blois

On 2013/10/16 21:25:33, vsm wrote: > lgtm > > https://codereview.chromium.org/27308006/diff/8001/sdk/lib/html/dart2js/html_dart2js.dart > File sdk/lib/html/dart2js/html_dart2js.dart (right): > ...

7 years, 2 months ago (2013-10-16 23:09:14 UTC) #3

blois

Committed patchset #1 manually as r28758 (presubmit successful).

7 years, 2 months ago (2013-10-16 23:09:41 UTC) #4

sra1

7 years, 2 months ago (2013-10-17 03:33:27 UTC) #5

Message was sent while issue was closed.

This change adds 77k to swarm

https://codereview.chromium.org/27308006/diff/8001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/27308006/diff/8001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:6401: -  @Creates('Null')
This annotation appears to have gone missing

Expand Messages | Collapse Messages