Issue 27308003: Document that concurrent modification is bad, m'kay.

Issue 27308003: Document that concurrent modification is bad, m'kay. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 2 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Document that concurrent modification is bad, m'kay. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=28711

Patch Set 3 : Cannot be misread as iterating changing the length. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
M	sdk/lib/collection/queue.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/core/iterable.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/core/list.dart	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download
M	sdk/lib/core/map.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/core/set.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

karlklose

DBC https://codereview.chromium.org/27308003/diff/1/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/27308003/diff/1/sdk/lib/core/iterable.dart#newcode32 sdk/lib/core/iterable.dart:32: * [CuncurrentModificationError] when it is detected. CuncurrentModificationError -> ...

7 years, 2 months ago (2013-10-15 14:15:13 UTC) #2

floitsch

LGTM. https://codereview.chromium.org/27308003/diff/1/sdk/lib/collection/queue.dart File sdk/lib/collection/queue.dart (right): https://codereview.chromium.org/27308003/diff/1/sdk/lib/collection/queue.dart#newcode17 sdk/lib/collection/queue.dart:17: * This goes both for using the [iteator] ...

7 years, 2 months ago (2013-10-15 15:32:23 UTC) #3

Lasse Reichstein Nielsen

https://codereview.chromium.org/27308003/diff/1/sdk/lib/collection/queue.dart File sdk/lib/collection/queue.dart (right): https://codereview.chromium.org/27308003/diff/1/sdk/lib/collection/queue.dart#newcode17 sdk/lib/collection/queue.dart:17: * This goes both for using the [iteator] directly, ...

7 years, 2 months ago (2013-10-16 05:41:24 UTC) #4

Lasse Reichstein Nielsen

https://codereview.chromium.org/27308003/diff/1/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://codereview.chromium.org/27308003/diff/1/sdk/lib/core/list.dart#newcode43 sdk/lib/core/list.dart:43: * by iterating an `Iterable` that is backed by ...

7 years, 2 months ago (2013-10-16 08:53:41 UTC) #5

Lasse Reichstein Nielsen

7 years, 2 months ago (2013-10-16 08:55:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r28711 (presubmit successful).

Expand Messages | Collapse Messages