Converting Polymer's WebComponentsLoaded to an onReady future

Converting Polymer's WebComponentsLoaded to an onReady future

This avoids double-firing of the event when the CustomElements polyfill is present and allows tests to wait for the future without worrying about missing the event.

BUG=
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28665

[Siggi Cherem (dart-lang), 2013-10-15 17:33:00]

lgtm! nice to see the cleaner tests.

https://codereview.chromium.org/27307004/diff/10001/pkg/polymer/lib/src/insta...
File pkg/polymer/lib/src/instance.dart (right):

https://codereview.chromium.org/27307004/diff/10001/pkg/polymer/lib/src/insta...
pkg/polymer/lib/src/instance.dart:73: /// Future indicating that the Polymer
library has been loaded and is ready
nit:
 - add empty line above comment
 - /// vs /** */ debate - I'm ok to leave it how it is (I'd like to switch to
/// everywhere), but so far I think most of this package has been using /** */,
so for consistency I lean towards that.

[blois, 2013-10-15 17:36:38]

https://codereview.chromium.org/27307004/diff/10001/pkg/polymer/lib/src/insta...
File pkg/polymer/lib/src/instance.dart (right):

https://codereview.chromium.org/27307004/diff/10001/pkg/polymer/lib/src/insta...
pkg/polymer/lib/src/instance.dart:73: /// Future indicating that the Polymer
library has been loaded and is ready
On 2013/10/15 17:33:00, Siggi Cherem (dart-lang) wrote:
> nit:
>  - add empty line above comment
>  - /// vs /** */ debate - I'm ok to leave it how it is (I'd like to switch to
> /// everywhere), but so far I think most of this package has been using /**
*/,
> so for consistency I lean towards that.

Done.

[blois, 2013-10-15 17:37:32]

Committed patchset #2 manually as r28665 (presubmit successful).