Document equality and compareTo of numbers.

Document equality and compareTo of numbers.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28635

[floitsch, 2013-10-15 11:36:17]

LGTM.

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode58
sdk/lib/core/num.dart:58: * Orders this value relative to `other`.
Why not simply "Compares `this` with [other]" ?

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode60
sdk/lib/core/num.dart:60: * Returns a negative number if `this` is considered
less than `other`,
-considered-

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode61
sdk/lib/core/num.dart:61: * zero if they are considered equal, and a positive
number if `this` is
-considered-

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode62
sdk/lib/core/num.dart:62: * considered greater than `other`.
-considered-

[karlklose, 2013-10-15 11:38:33]

DBC

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode38
sdk/lib/core/num.dart:38: * If you can avoid NaN values, the reamining doubles
do have a proper eqality
reamining -> remaining.

[Lasse Reichstein Nielsen, 2013-10-15 11:58:08]

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode38
sdk/lib/core/num.dart:38: * If you can avoid NaN values, the reamining doubles
do have a proper eqality
On 2013/10/15 11:38:33, karlklose wrote:
> reamining -> remaining.

Done.

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode58
sdk/lib/core/num.dart:58: * Orders this value relative to `other`.
Works.

https://codereview.chromium.org/27302003/diff/1/sdk/lib/core/num.dart#newcode60
sdk/lib/core/num.dart:60: * Returns a negative number if `this` is considered
less than `other`,
Removed, but this begs the question what it means to be "equal to", since it is
not 'operator=='.

[Lasse Reichstein Nielsen, 2013-10-15 11:59:07]

Committed patchset #2 manually as r28635 (presubmit successful).