Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Issue 27300003: Change "typedef" to "class" in core library and related tests. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

Change "typedef" to "class" in core library and related tests. R=floitsch@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=28712

Patch Set 1 #

Patch Set 2 : Found two more. #

Patch Set 3 : More tests fixed. Made some types abstract. #

Patch Set 4 : Update some dart2js tests and unparser. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -154 lines) Patch
M pkg/observe/lib/src/change_notifier.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/observe/lib/src/observable.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_collection_dev/list.dart View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/unparser.dart View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/list.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_test.dart View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 2 3 1 chunk +14 lines, -11 lines 0 comments Download
M tests/language/mixin_illegal_constructor_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/language/mixin_illegal_cycles_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/language/mixin_illegal_object_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_illegal_static_access_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_illegal_super_use_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/mixin_illegal_superclass_test.dart View 1 chunk +24 lines, -24 lines 0 comments Download
M tests/language/mixin_illegal_syntax_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/language/mixin_implements2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_implements_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/language/mixin_is_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/language/mixin_issue10216_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/mixin_method_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/mixin_mixin2_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/mixin_mixin3_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language/mixin_mixin4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/mixin_mixin5_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/mixin_mixin6_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/mixin_mixin7_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/mixin_mixin_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/mixin_naming_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_override_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_this_use_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_type_parameter1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_type_parameter2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_type_parameter4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/mixin_type_parameters_errors_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/language/mixin_type_parameters_mixin_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/mixin_type_parameters_super_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/mixin_typedef_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/generic_mixin_applications_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/mirrors/typedef_metadata_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-15 08:28:16 UTC) #1
Lasse Reichstein Nielsen
Blocked on datbug.com/13907
7 years, 2 months ago (2013-10-15 08:28:38 UTC) #2
floitsch
LGTM.
7 years, 2 months ago (2013-10-15 08:56:36 UTC) #3
hausner
I just checked in the VM change. You may have to update a couple of ...
7 years, 2 months ago (2013-10-15 16:16:21 UTC) #4
Lasse Reichstein Nielsen
Excellent. I changed the dart2js unparser. Johnni, please check it (just the last patch).
7 years, 2 months ago (2013-10-16 08:36:08 UTC) #5
Johnni Winther
dart2js changes LGTM
7 years, 2 months ago (2013-10-16 08:52:24 UTC) #6
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-16 09:03:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r28712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698