Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 27275002: Add test for ClassMirror.mixin. Rename the mixin application test. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
ahe, gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test for ClassMirror.mixin. Rename the mixin application test. R=ahe@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=28660

Patch Set 1 #

Total comments: 3

Patch Set 2 : long lines #

Patch Set 3 : long lines #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -350 lines) Patch
M tests/lib/lib.status View 1 2 chunks +3 lines, -2 lines 0 comments Download
A + tests/lib/mirrors/mixin_application_test.dart View 1 14 chunks +33 lines, -26 lines 0 comments Download
M tests/lib/mirrors/mixin_test.dart View 1 2 1 chunk +32 lines, -322 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-14 23:55:25 UTC) #1
gbracha
lgtm
7 years, 2 months ago (2013-10-14 23:58:29 UTC) #2
ahe
LGTM! https://codereview.chromium.org/27275002/diff/1/tests/lib/mirrors/mixin_application_test.dart File tests/lib/mirrors/mixin_application_test.dart (right): https://codereview.chromium.org/27275002/diff/1/tests/lib/mirrors/mixin_application_test.dart#newcode122 tests/lib/mirrors/mixin_application_test.dart:122: 'Class(s(MixinApplicationA) in s(test.mixin_application_test), top-level)', Long line, more below. ...
7 years, 2 months ago (2013-10-15 06:58:47 UTC) #3
rmacnak
https://codereview.chromium.org/27275002/diff/1/tests/lib/mirrors/mixin_application_test.dart File tests/lib/mirrors/mixin_application_test.dart (right): https://codereview.chromium.org/27275002/diff/1/tests/lib/mirrors/mixin_application_test.dart#newcode122 tests/lib/mirrors/mixin_application_test.dart:122: 'Class(s(MixinApplicationA) in s(test.mixin_application_test), top-level)', On 2013/10/15 06:58:48, ahe wrote: ...
7 years, 2 months ago (2013-10-15 16:55:30 UTC) #4
rmacnak
7 years, 2 months ago (2013-10-15 16:55:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r28660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698